This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
token js: create new offchain helper #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2024
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
buffalojoec
force-pushed
the
01-10-token_client_refactor_transfer_to_use_new_offchain_helper
branch
from
8df6a4b to
8bda3ed
Compare
buffalojoec
force-pushed
the
01-10-token_js_create_new_offchain_helper
branch
from
b835aee to
9b33a88
Compare
buffalojoec
changed the base branch from
01-10-token_client_refactor_transfer_to_use_new_offchain_helper
to
01-10-token_2022_test_refactor_transfer_hook_test_to_use_new_offchain_helper
This was referenced Jan 10, 2024
buffalojoec
force-pushed
the
01-10-token_2022_test_refactor_transfer_hook_test_to_use_new_offchain_helper
branch
from
7de4df7 to
0b076b1
Compare
buffalojoec
force-pushed
the
01-10-token_js_create_new_offchain_helper
branch
from
9b33a88 to
7bf9077
Compare
buffalojoec
changed the base branch from
01-10-token_2022_test_refactor_transfer_hook_test_to_use_new_offchain_helper
to
01-10-token_2022_repair_onchain_helper
buffalojoec
force-pushed
the
01-10-token_2022_repair_onchain_helper
branch
from
ac35de5 to
b47b84e
Compare
buffalojoec
force-pushed
the
01-10-token_js_create_new_offchain_helper
branch
from
7bf9077 to
2b6b769
Compare
buffalojoec
force-pushed
the
01-10-token_2022_repair_onchain_helper
branch
from
b47b84e to
a7e399c
Compare
buffalojoec
force-pushed
the
01-10-token_js_create_new_offchain_helper
branch
from
2b6b769 to
c7e787b
Compare
joncinque
reviewed
Jan 11, 2024
buffalojoec
force-pushed
the
01-10-token_2022_repair_onchain_helper
branch
from
a7e399c to
ed3fca4
Compare
joncinque
previously approved these changes
Jan 11, 2024
buffalojoec
force-pushed
the
01-10-token_js_create_new_offchain_helper
branch
2 times, most recently
from
55dfa61 to
dc2441d
Compare
Merge activity
|
buffalojoec
force-pushed
the
01-10-token_2022_repair_onchain_helper
branch
from
ed3fca4 to
367eedb
Compare
Base automatically changed from
01-10-token_2022_repair_onchain_helper
to
master
January 11, 2024 21:24
buffalojoec
force-pushed
the
01-10-token_js_create_new_offchain_helper
branch
from
dc2441d to
07b2e6b
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR to round off the changes required to fix #6064.
Previously, the offchain helpers for adding extra metas to instructions have
been replaced with new ones in the SPL Transfer Hook interface and Token2022.
This PR follows suit and adds a new helper to SPL Token JS.
The new helper,
addExtraAccountMetasForExecute(..), mirrors the Rust helper inSPL Transfer Hook interface, requiring the parameters for an
ExecuteInstructionto be passed into the function directly.This change also adds a public function for creating an
ExecuteInstruction, incase developers wish to create such an instruction for directly sending
instructions to their transfer hook program.
These existing functions have been updated to use the new helper:
createTransferCheckedWithTransferHookInstruction(..)createTransferCheckedWithFeeAndTransferHookInstruction(..)Closes #6064